> > 
> Would it be possible to include an explicit link to the PR too in the
> email?
> 
> It's attached to the commit via some GH magic but it's not a link in the
> commit itself, and I'm also not sure how reliable that github detection
> is in the longrun.

That was the original idea yes... But for some technical reason, we had to drop 
this idea and we decided it was still OK to only provide a link to the commit 
page (from where you can find the pull request). But I can give it another try 
now that the fist step looks ok.

The reason we dropped it is that the pull request info is available in the 
workflow when executed in the "pull request" context, but as this context can 
execute things from outside the projects, it doesn't have access to the 
repository's secrets (i.e. mail password)[1]. The initial version had this, and 
tests were all good... until we tried it with a pull request created with a 
base outside the Rust-GCC org.

So we moved to the "push"[2] context where we only see "new commits" and github 
doesn't provide any pull request info. We would need to find this ourself 
(using the same "GH magic" that can link a commit to its pull request), which 
is completely possible, but not automatic.

Also, I'm clearly not an expert, so I'd be happy to be proved wrong here and 
provided with an example that makes this feature easy :)

Marc

[1]: 
https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#running-your-pull_request-workflow-when-a-pull-request-merges
[2]: 
https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#push

Reply via email to