On Tue, 3 Apr 2012, Pawe�~B Sikora wrote:

> i'm only suggesting that astyle (or another tool) can be used in svn 
> pre-commit
> hook to verifying gnu formatting rules (incoming files can be extracted from

I think it's a bad idea to check anything in a pre-commit hook that isn't 
also covered by a normal build and testsuite run.  Commit time is too late 
for detecting problems with patches; if you want automatic style checks 
then make them cause the build or testsuite run to fail if there are 
problems.

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to