On Thu, 20 Aug 2020, Senthil Kumar Selvaraj wrote: > What I didn't understand was the (set-attr "cc<cccc><ccnz><ccnzvc>") > part - as far I can tell, this results in (set_attr "cc_enabled" ...) in > all of the three substituted patterns, so I wondered why not just have > (set_attr "cc_enabled" ...) in the original define_insn instead. > > I now realize that with (set-attr "cc<cccc><ccnz><ccnzvc>"), the original > unsubstituted pattern will have only a (set_attr "cc" ...) and would > therefore not match the attr check for "enabled" - correctly so, as the > original insn pattern clobbers CRIS_CC0_REGNUM. Did I get that right?
Aha: yes, correct. Attribute "cc" is now "unused" in the original (un-subst:ed) insn. Commit a82c9fb3. brgds, H-P