Hi Chaitanya,

Good catch! Yes, this was a silly mistake, the line should have been
above the break. I have fixed this in the master version. Will you apply
this fix in the OGR copy or should I do it?

Daniel

Chaitanya kumar CH wrote:
Daniel,

You added some code in MIFFile::AddFieldNative() in mitab_miffile.cpp in the revision 14983 <http://trac.osgeo.org/gdal/changeset/14983/trunk/gdal/ogr/ogrsf_frmts/mitab/mitab_miffile.cpp>. ( http://trac.osgeo.org/gdal/changeset/14983/trunk/gdal/ogr/ogrsf_frmts/mitab/mitab_miffile.cpp )

In the line 1742 of the new version, the statement "m_nVersion = MAX(m_nVersion, 900);" comes after the "break;" making it unreachable. Can you check if it is desirable? Shall I move it to above the "break;" statement?

Best regards,
--
Chaitanya kumar CH.


--
Daniel Morissette
http://www.mapgears.com/
_______________________________________________
gdal-dev mailing list
[email protected]
http://lists.osgeo.org/mailman/listinfo/gdal-dev

Reply via email to