On Thu, Apr 17, 2014 at 3:01 PM, Even Rouault <[email protected]>wrote:
> > I suppose, but the problem is that without it the whole thing becomes > > useless for large datasets (> 100k features) due to GME restrictions. I > > just thought that it would be good to have a GME driver that works on > those > > large tables too. :) > > The problem is that at some point we must take a snapshot and say "hey, > this is > GDAL 1.11, the latest and greatest, use it please". I think it is OK if new > drivers are still a bit experimental. > > Ok, no need for it then. Do you want me to roll my changes back from the 1.11 branch or apply my patch to it? > Reviewing the commit, I think that it has at least one issue because > SetSpatialFilter() will segfault in switch( poGeomIn->getGeometryType() ) > if > passed a NULL geometry, which is perfectly legal, in order to uninstall a > spatial filter. > Did you test the driver with the test_ogrsf utility ? (cd apps; make > test_ogrsf) > > Noo :( I was too tired and forgot. I only ran my own python test which doesn't try to unset the spatial filter. Will need to add that test later. Anyways just committed a fix for the crash and now test_ogrsf works mostly. A few errors, but nothing that causes a crash. They are mostly GME -related things, like the it doesn't support infinity and big numbers. So will add a check for that later. --Wolf
_______________________________________________ gdal-dev mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/gdal-dev
