Hello Dmitry, Thank you for your feedback. I will look into all the files in libpng once again.
About the python support - I think I found the problem, I guess that when I was downloading the source, due to poor net at the time a few files didn't get through. So now I'm downloading again, and I'll let you know if there are any more issues. Cheers Tanuj On Tue, Mar 22, 2016 at 1:33 AM, Dmitry Baryshnikov <[email protected]> wrote: > Hi Tanuj, > > I compare current libpng folder and previous one: > 1. You include a lot of files needed to build standalone library, but not > need in GDAL sources tree (like configure, CMakeLists.txt, etc.). > 2. The makefile.vc removed and it seems to me the windows build will fail > in that case. > 3. There was a libpng_gdal.patch file, are you sure that this file is not > necessary? > 4. You included several files need for libpng unit testing, but not needed > by GDAL. According to GNUMakefile in png folder, it get all *.c files from > libpng folder, so we need minimum set of *.c and *.h files there (but > enough for VC building too). > > About python support - do you did sudo make install (Linux)? The only > building is not enough to have python bindings work (there is a tick with > PYTHONPATH, but not sure that it works. > > Best regards, > Dmitry > > 20.03.2016 10:15, Tanuj Kumar пишет: > > Hello Dmitry, > Sorry for the long delay, my exams had the better of me, but now they're > over :) . > I have updated libpng 1.6.21 and i have created a pull request after > removing files from original libpng 1.6.21 that I think would not be > required as a library in GDAL. > All test on travis have been passed, and you can see the pull request here > : https://github.com/OSGeo/gdal/pull/108 > > As for building on desktop, I configured with python, but the same issue > of "ImportError: No module named osgeo persists". I am trying to understand > why this is happening, and am working out how to get rid of this problem by > reading GDAL wiki. > > Cheers > Tanuj > > On Tue, Mar 15, 2016 at 1:24 AM, Dmitry Baryshnikov <[email protected]> > wrote: > >> Hi Tanuj, >> >> The error: ImportError: No module named osgeo >> is because you build gdal without python support (you need python with >> developers headers). >> On Linux Linux this is done via such command: >> ./configure --with-python ... <other config options> >> >> On Windows it depends how you build. On Windows I launch separate tests >> successfully but never try the whole tests (run_all.py). >> >> Best regards, >> Dmitry >> >> 14.03.2016 19:11, Tanuj Kumar пишет: >> >> Hello Dmitry, >> I was reading up on the gdalautotest wiki( >> <http://trac.osgeo.org/gdal/wiki/TestingNotes> >> http://trac.osgeo.org/gdal/wiki/TestingNotes), and it says, "After >> building with either the old or new generation python bindings, and >> installing them (or adding them to your path from the build tree)..." >> >> I could not understand what that means. I guess this is important because >> when I tried the commands given on that page, I got the following error : >> >> File "./run_all.py", line 37, in <module> >> import gdaltest >> File"pymod/gdaltest.py", line 37, in <module> >> from osgeo import gdal >> ImportError: No module named osgeo >> >> >> Now, as far as I could understand, it is importing a file called >> "gdal.py" from a folder called osgeo. I searched for it, and got its path >> as "gdal/swig/python/osgeo, whereas the autotest folder is separate. >> So my guess is I have to somehow specify the path of "gdal.py" >> >> Could you or anyone please guide me on how to proceed with this? >> >> Thanks >> Tanuj >> >> On Sat, Mar 12, 2016 at 11:00 PM, Tanuj Kumar < <[email protected]> >> [email protected]> wrote: >> >>> Alright, thank you very much, I'll get to work on it! >>> >>> On Sat, Mar 12, 2016 at 10:47 PM, Dmitry Baryshnikov < >>> <[email protected]>[email protected]> wrote: >>> >>>> Hi Tanuj, >>>> >>>> I wrote a big letter to the list. There is some answers there. Also I >>>> add comments below. >>>> >>>> Best regards, >>>> Dmitry >>>> >>>> 12.03.2016 10:36, Tanuj Kumar пишет: >>>> >>>> Sorry for replying so late, got caught up in an exam :) >>>> >>>> I replaced libpng folder of gdal (frmts/png/libpng) with libpng 1.6.21. >>>> And then used ./configure and make install on this test version of gdal, >>>> which installed successfully. I used gdalinfo on a png file provided with >>>> the libpng 1.6.21 source, to check if it was OK, and it successfully gave >>>> the png file details. >>>> >>>> Is that enough to check the build on the computer? >>>> >>>> No, the autotests must be passed. >>>> >>>> >>>> I have also tested the gdal library with libpng 1.6.21 on Travis, and >>>> the build succeeded. >>>> <https://travis-ci.org/Raeburn1687/gdal/builds/115487530> >>>> https://travis-ci.org/Raeburn1687/gdal/builds/115487530 >>>> >>>> Would all that be enough to check whether the update was succesful? >>>> >>>> I expected that travis from main gdal repo checked your PR. >>>> >>>> >>>> PS - Although I have copied the files from libpng 1.6.21 source to the >>>> gdal libpng folder, how would I know if any of those files are not required >>>> for gdal? >>>> >>>> You need to see the previous version. Some files not needed (i.e. >>>> configures and so on, which already comes from gdal, but legal notice must >>>> be present (license, autors, etc.) ). Don't hesitate to ask in list. >>>> >>>> >>>> Thank you >>>> >>>> Tanuj >>>> >>>> On Thu, Mar 10, 2016 at 2:07 PM, Dmitry Baryshnikov < >>>> <[email protected]>[email protected]> wrote: >>>> >>>>> Hi Tanuj, >>>>> 09.03.2016 13:17, Tanuj Kumar пишет: >>>>> >>>>> Yes, I have looked at the ideas list, and I am currently reading up on >>>>> idea no. 16, which is, implementing support for the proposed standard for >>>>> incrementally parseable GeoJSON data. >>>>> >>>>> Also, I was thinking that maybe I could work on ticket no 6294, >>>>> <https://trac.osgeo.org/gdal/ticket/6294> >>>>> https://trac.osgeo.org/gdal/ticket/6294 >>>>> after I've studied about the GSoC idea, which is not really a bug, but >>>>> an enhancement. But if there are any other tickets that you or anyone else >>>>> would like to recommend me to work on, I'd love to see them too! >>>>> >>>>> I think this rather arguing ticket as the bool is not exist in plain >>>>> C, and duplication functions seems to me not good idea. >>>>> I think this ticket <https://trac.osgeo.org/gdal/ticket/6185> >>>>> https://trac.osgeo.org/gdal/ticket/6185 is good for: 1. building >>>>> GDAL, 2. Testing via TraviC on GitHub. By the way the libpng version is >>>>> 1.6.21 or maybe higher. >>>>> >>>>> Anyhow, you have to try to build gdal and test it with autotests from >>>>> appropriate folder. >>>>> >>>>> >>>>> Now, about the GSoC idea, do I need to know JSON( or GeoJSON, for that >>>>> matter) to work on it? I only ask because the idea lists C/C++ as the >>>>> required skills, but I feel that maybe this work would involve knowing >>>>> JSON >>>>> too... >>>>> >>>>> Yes, certainly. But JSON are very simple. Also GeoJSON spec. can be >>>>> found here <http://geojson.org/>http://geojson.org/Thanks and >>>>> regards, >>>>> >>>>> >>>>> Tanuj >>>>> >>>>> >>>>> On Wed, Mar 9, 2016 at 2:58 PM, Dmitry Baryshnikov < >>>>> <[email protected]>[email protected]> wrote: >>>>> >>>>>> Hi, Tanuj >>>>>> >>>>>> I'll look for opened tickets for you, or maybe others can recommend >>>>>> some for you. >>>>>> >>>>>> By the way, do you see the idea list ( >>>>>> <https://trac.osgeo.org/gdal/wiki/SummerOfCode#a2016IdeasList> >>>>>> https://trac.osgeo.org/gdal/wiki/SummerOfCode#a2016IdeasList)? >>>>>> The ideas are not ranked yet - the numbers in the list - are only in >>>>>> order. >>>>>> This is a task for us to rank the ideas. >>>>>> But, have you some preferable idea (or ideas) for GSoC from this list >>>>>> or maybe you have got own? >>>>>> >>>>>> Best regards, >>>>>> Dmitry >>>>>> >>>>>> 04.03.2016 16:11, Tanuj Kumar пишет: >>>>>> >>>>>> Hello, >>>>>> I am interested in applying for GSoC this year. Currently, I am >>>>>> reading up on the GDAL Summer of Code ideas list. I know C++ and C, and I >>>>>> have some experience on working on linux. >>>>>> Could the mentors please recommend a bug for me to work on, I'd >>>>>> really love to start off as soon as possible! >>>>>> >>>>>> Thank you, >>>>>> >>>>>> Tanuj Kumar >>>>>> Birla institute of Technology and Science >>>>>> Pilani, Rajasthan, >>>>>> India >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> gdal-dev mailing >>>>>> [email protected]http://lists.osgeo.org/mailman/listinfo/gdal-dev >>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> gdal-dev mailing list >>>>>> <[email protected]>[email protected] >>>>>> <http://lists.osgeo.org/mailman/listinfo/gdal-dev> >>>>>> http://lists.osgeo.org/mailman/listinfo/gdal-dev >>>>>> >>>>> >>>>> >>>>> Best regards, >>>>> Dmitry >>>>> >>>>> >>>> >>>> >>> >> >> > >
_______________________________________________ gdal-dev mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/gdal-dev
