Ouch. My take is that caching headers like that should be very strongly discouraged. Maintaining code with people doing that really isn't a reasonable proposition.
+1 going with 2) with filing a bug for someone else to do 3). On Mon, Apr 24, 2017 at 10:20 AM, Even Rouault <[email protected]> wrote: > Hi, > > > > > - Shape: do not export Shapelib symbols for builds > > > --with-hide-internal-symbols (#6860) > > > > It turns out that the above change breaks QGIS 2.18 build, in particular > the DXF2SHP converter native plugin, since it does a nasty trick: the QGIS > build tree has the shapelib 2.10 includes files, but relies on linking > against shapelib symbols exported by libgdal. The plugin apparently no > longer exists in QGIS master, which builds fine against GDAL 2.2beta2. > > > > So I'm not sure what to do: > > 1) revert #6860 and export again shapelib symbols from GDAL. But this > apparently breaks some other workflows > > 2) let distributions apply a patch to do this revert, while they use QGIS > 2.18 or other code that depend on GDAL exporting shapelib symbols > > 3) Change DXF2SHP plugin to use OGR API instead of shapelib, but I'm not > feeling like I would do that myself. > > > > My opinion would be to favor 2) > > > > Opinions ? > > > > Even > > > > -- > > Spatialys - Geospatial professional services > > http://www.spatialys.com > > _______________________________________________ > gdal-dev mailing list > [email protected] > https://lists.osgeo.org/mailman/listinfo/gdal-dev > -- -- http://schwehr.org
_______________________________________________ gdal-dev mailing list [email protected] https://lists.osgeo.org/mailman/listinfo/gdal-dev
