On mercredi 17 mai 2017 08:26:00 CEST Martin Chapman wrote: > Nicolas, > > > > Looks good bud! Thanks!
I've just applied it to trunk, but couldn't really test it since it seems my MrSID version doesn't have those #define Even > > > > Best regards, > > Martin > > > > From: SIMON Nicolas [mailto:[email protected]] > Sent: Wednesday, May 17, 2017 4:41 AM > To: Martin Chapman > Cc: [email protected]; Even Rouault > Subject: RE: [gdal-dev] MrSID Color Spaces > > > > Martin, > > Could you test this patch ? > > Nicolas > > > > De : gdal-dev [mailto:[email protected]] De la part de Even > Rouault > Envoyé : mardi 16 mai 2017 18:28 > À : Martin Chapman > Cc : [email protected] > Objet : Re: [gdal-dev] MrSID Color Spaces > > On mardi 16 mai 2017 10:13:52 CEST Martin Chapman wrote: > > Even or Frank or whoever it may concern, > > > > > > > > > > > > > > > > Not a big deal but I was trying to open a JP2 file using the MrSID driver > > > > and noticed that the mrsiddataset.cpp does not identify the color spaces > > > > MRSID_LTI_COLORSPACE_GRAYSCALEA and MRSID_LTI_COLORSPACE_GRAYSCALEA_PM > > > > configurations in the MrSIDRasterBand() constructor. I happen to have a > > two > > > band JP2 that is a grayscale image with an alpha channel. The color > > > > interpretation comes back as GCI_undefined. Not that important but if you > > > > ever feel like fixing it, that would be nice. > > > > > > > > > > > > > > > > The fix would go somewhere close to line 485 in mrsiddataset.cpp. > > Basically > > > just need to add a couple of more case statements in the switch statement. > > Martin, > > > > Seems you are closed to a patch. Can you provide it ? > > > > Even -- Spatialys - Geospatial professional services http://www.spatialys.com
_______________________________________________ gdal-dev mailing list [email protected] https://lists.osgeo.org/mailman/listinfo/gdal-dev
