On Fri, 22 Jun 2018, Even Rouault wrote:
I've issued a release candidate for GDAL 2.3.1. This adds 75 bug fixes on top
of 2.3.0. The C and C++ API and ABI are unchanged.
The source is available at:
http://download.osgeo.org/gdal/2.3.1/gdal-2.3.1rc1.tar.xz
http://download.osgeo.org/gdal/2.3.1/gdal-2.3.1rc1.tar.gz
http://download.osgeo.org/gdal/2.3.1/gdal231rc1.zip
When building this on Scientific Linux 6.9 I found *one* warning,
/bin/sh /home/werdna/gdal2.3.1rc1/gdal-2.3.1/libtool --mode=compile
--silent --tag=CXX g++ -DHAVE_AVX_AT_COMPILE_TIME
-DHAVE_SSSE3_AT_COMPILE_TIME -DHAVE_SSE_AT_COMPILE_TIME -g -O2 -Wall
-Wextra -Winit-self -Wunused-parameter -Wformat -Werror=format-security
-Wno-format-nonliteral -Wlogical-op -Wshadow -Werror=vla -Wdate-time
-Wnull-dereference -Wduplicated-cond -Wfloat-conversion
-Wmissing-declarations -Wnon-virtual-dtor -Woverloaded-virtual
-fno-operator-names -Wzero-as-null-pointer-constant -Wsuggest-override
-Wimplicit-fallthrough -I.. -I../sqlite -I../../../frmts/mem
-I/usr/include -DGNM_ENABLED -I/home/werdna/gdal2.3.1rc1/gdal-2.3.1/port
-I/usr/include -I/usr/include/cfitsio -DGDAL_COMPILATION
-DSQLITE_HAS_COLUMN_METADATA -c -o ogrgeopackagetablelayer.o
ogrgeopackagetablelayer.cpp
ogrgeopackagetablelayer.cpp: In member function 'virtual OGRErr
OGRGeoPackageTableLayer::ISetFeature(OGRFeature*)':
ogrgeopackagetablelayer.cpp:1856:100: warning: zero as null pointer constant
[-Wzero-as-null-pointer-constant]
int err = sqlite3_prepare_v2(m_poDS->GetDB(), osCommand, -1,
&m_poUpdateStatement, NULL);
so I attach a patch.
--
Andrew C. Aitchison Cambridge, UK
[email protected]--- gdal-2.3.1/ogr/ogrsf_frmts/gpkg/ogrgeopackagetablelayer.cpp.orig
2018-06-22 09:40:17.000000000 +0100
+++ gdal-2.3.1/ogr/ogrsf_frmts/gpkg/ogrgeopackagetablelayer.cpp 2018-06-23
10:43:09.675549558 +0100
@@ -1853,7 +1853,7 @@ OGRErr OGRGeoPackageTableLayer::ISetFeat
CPLString osCommand = FeatureGenerateInsertSQL(poFeature, true,
true);
/* Prepare the SQL into a statement */
- int err = sqlite3_prepare_v2(m_poDS->GetDB(), osCommand, -1,
&m_poUpdateStatement, NULL);
+ int err = sqlite3_prepare_v2(m_poDS->GetDB(), osCommand, -1,
&m_poUpdateStatement, nullptr);
if ( err != SQLITE_OK )
{
CPLError( CE_Failure, CPLE_AppDefined,
_______________________________________________
gdal-dev mailing list
[email protected]
https://lists.osgeo.org/mailman/listinfo/gdal-dev
