+1 Kurt Awesome!! It's great to see that my work in https://github.com/schwehr/gdal-autotest2/tree/master/python is obsolete.
Some very minor suggestions: - "Support testing under Python 2 & Python 3 (2.7+)" Move the (2.7+) to be with Python 2. - Mention that Fiona and Rasterio also use pytest - Add the word "existing" so it's obvious right off that the first example is not new. "A typical GDAL python unit test:" -> "A typical existing GDAL python unit test:" - Consider including an example with a float comparison. Those drive me nuts in the old style and I want to make sure people know about how to do that with pytest https://stackoverflow.com/questions/8560131/pytest-assert-almost-equal - Can you give a rough comparison of how long the existing and new styles take to run. A quick spot check says that they are pretty close with only 1604 looking to get worrisome. Are there any things that could be listed where people contribute that might speed up the testing? - Is there a way for folks with large machines / cloud instances to run the tests quicker without a lot of fiddling? - I'm not a fan of GH and PR abbreviations. Since this is on trac, it would be worth being more verbose On Wed, Dec 5, 2018 at 2:41 PM Craig de Stigter < craig.destig...@koordinates.com> wrote: > Hi > > I appreciate your comments on the pytest proposal and all the support to > help get it this far. Given no actionable improvements have been suggested, > and the feedback thus far seems encouraging... > > I move to adopt RFC 72: Run tests with pytest. > > https://trac.osgeo.org/gdal/wiki/rfc72_pytest > > > Cheers > Craig de Stigter > _______________________________________________ > gdal-dev mailing list > gdal-dev@lists.osgeo.org > https://lists.osgeo.org/mailman/listinfo/gdal-dev -- -- http://schwehr.org
_______________________________________________ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev