Even,

You are correct.

As you can see in the code above those lines is that it is possible to run in 
debugging mode to check if the call to OCIServerVersion is been parsed 
correctly.

Best regards,

Ivan
________________________________
From: Even Rouault <[email protected]>
Sent: Tuesday, September 15, 2020 10:33 AM
To: [email protected] <[email protected]>
Cc: Ivan Lucena <[email protected]>; Victoria Ponz-Sarvise 
<[email protected]>
Subject: Re: [gdal-dev] ogr2ogr with ORACLE driver: limitation on table name 
size?


Ivan,



> https://github.com/OSGeo/gdal/blob/70a2ec1795c3e01aeaf1ac3c0f7c69a3f0fa2ca5/

> gdal/ogr/ogrsf_frmts/oci/ogrocisession.cpp#L316



The logic



if( nServerVersion >= 12 && nServerRelease >= 2 )



looks wrong to me. It will not work for 13.0 for example



Shouldn't that be



if( nServerVersion > 12 || (nServerVersion == 12 && nServerRelease >= 2) )



?



That said that doesn't explain issues with 12.2



Even



--

Spatialys - Geospatial professional services

http://www.spatialys.com
_______________________________________________
gdal-dev mailing list
[email protected]
https://lists.osgeo.org/mailman/listinfo/gdal-dev

Reply via email to