Hi Kurt,
thanks for the feedback (and invalidating my prophecy that rc2 would be
the last one :-))
should be fixed with
https://gitlab.com/libtiff/libtiff/-/merge_requests/444.
Is that enough to get the build working for you before I generate a rc3
with that extra fix ?
Even
Le 13/12/2022 à 22:39, Kurt Schwehr a écrit :
I'm seeing mac osx and ios failures at my most recent sync of
c4516f9dc72bad7f2c4a8f704169afa0342e44ca
<https://www.google.com/url?sa=D&q=https%3A%2F%2Fgitlab.com%2Flibtiff%2Flibtiff%2Fcommit%2Fc4516f9dc72bad7f2c4a8f704169afa0342e44ca>:
third_party/tiff/libtiff/tif_dir.c:1988:17: error: format specifies
type 'unsigned short' but the argument has type 'tdir_t' (aka
'unsigned int') [-Werror,-Wformat]
*nextdirnum, *nextdiroff, *nextdiroff,
(int)(*nextdirnum) - 1);
^~~~~~~~~~~
third_party/tiff/libtiff/tif_dir.c:2164:27: error: format specifies
type 'unsigned short' but the argument has type 'tdir_t' (aka
'unsigned int') [-Werror,-Wformat]
dirn);
^~~~
On Tue, Dec 13, 2022 at 12:39 PM Even Rouault
<even.roua...@spatialys.com> wrote:
Hi,
The changes in IFD loop detection are non-trivial enough to justify a
rc2, so here it is:
- https://download.osgeo.org/libtiff/tiff-4.5.0rc2.tar.gz
- https://download.osgeo.org/libtiff/tiff-4.5.0rc2.tar.gz.sig
- https://download.osgeo.org/libtiff/tiff-4.5.0rc2.tar.xz
- https://download.osgeo.org/libtiff/tiff-4.5.0rc2.tar.xz.sig
- https://download.osgeo.org/libtiff/tiff-4.5.0rc2.zip
- https://download.osgeo.org/libtiff/tiff-4.5.0rc2.zip.sig
Hopefully this will be the final release candidate for 4.5.0. Please
test and report.
The changes since rc1 are:
- restore formatting of tiffvers.h so that FindTIFF.cmake can infer
libtiff version number
- addition of TIFFLIB_MAJOR_VERSION, TIFFLIB_MINOR_VERSION,
TIFFLIB_MICRO_VERSION in tiffvers.h
- introduction of TIFFLIB_AT_LEAST(major, minor, micro) macro in
tiffvers.h
- CMake: restore BUILD_SHARED_LIBS=ON default setting for
top-level builds
- IFD loop detection: changed algorithm to use a hashset/hashmap for
good performance
- tdir_t type updated to uint32_t. This type is now used for the
return
value of TIFFCurrentDirectory and TIFFNumberOfDirectories, and as the
argument of TIFFSetDirectory and TIFFUnlinkDirectory
- Increase the maximum number of IFDs that libtiff can browse through
from 65535 to 1048576. This value is a build-time setting,
available in
tif_config.h, that can be configured with CMake's
TIFF_MAX_DIR_COUNT and
variable or autoconf's --with-max-dir-count option.
- tiffinfo: support more than 64k IFDs.
Even
--
http://www.spatialys.com
My software is free, but my time generally not.
_______________________________________________
Tiff mailing list
t...@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/tiff
--
http://www.spatialys.com
My software is free, but my time generally not.
_______________________________________________
gdal-dev mailing list
gdal-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/gdal-dev
