Hello crpince, clambert,
I'd like you to do a code review. Please execute
g4 diff -c 8148628
or point your web browser to
http://mondrian/8148628
to review the following code:
Change 8148628 by [EMAIL PROTECTED] on 2008/09/01 13:11:01 *pending*
Bumps JSON network location provider version number to 1.1 now that
altitude and accuracies are doubles.
R=crpince,clambert
[EMAIL PROTECTED]
DELTA=2 (0 added, 0 deleted, 2 changed)
OCL=8148628
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/network_location_request.cc#22
edit
...
//depot/googleclient/gears/opensource/gears/test/testcases/internal_tests.js#32
edit
2 delta lines: 0 added, 0 deleted, 2 changed
Also consider running:
g4 lint -c 8148628
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8148628 by [EMAIL PROTECTED] on 2008/09/01 13:11:01 *pending*
Bumps JSON network location provider version number to 1.1 now that
altitude and accuracies are doubles.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/network_location_request.cc#22
edit
...
//depot/googleclient/gears/opensource/gears/test/testcases/internal_tests.js#32
edit
====
//depot/googleclient/gears/opensource/gears/geolocation/network_location_request.cc#22
-
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/geolocation/network_location_request.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/geolocation/network_location_request.cc
2008-09-02 19:04:09.000000000 +0100
+++ googleclient/gears/opensource/gears/geolocation/network_location_request.cc
2008-09-02 18:58:48.000000000 +0100
@@ -32,7 +32,7 @@
#include "third_party/jsoncpp/value.h"
#include "third_party/jsoncpp/writer.h"
-static const char *kGearsNetworkLocationProtocolVersion = "1.0";
+static const char *kGearsNetworkLocationProtocolVersion = "1.1";
static const char *kLatitudeString = "latitude";
static const char *kLongitudeString = "longitude";
====
//depot/googleclient/gears/opensource/gears/test/testcases/internal_tests.js#32
-
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/test/testcases/internal_tests.js
====
# action=edit type=text
--- googleclient/gears/opensource/gears/test/testcases/internal_tests.js
2008-09-02 19:04:09.000000000 +0100
+++ googleclient/gears/opensource/gears/test/testcases/internal_tests.js
2008-09-02 18:58:59.000000000 +0100
@@ -393,7 +393,7 @@
'}, ' +
'"radio_type" : "gsm", ' +
'"request_address" : true, ' +
- '"version" : "1.0", ' +
+ '"version" : "1.1", ' +
'"wifi_towers" : [ { ' +
'"age" : 15, ' +
'"channel" : 19, ' +
