Hello bpm,
I'd like you to do a code review. Please execute
g4 diff -c 8199719
or point your web browser to
http://mondrian/8199719
to review the following code:
Change 8199719 by [EMAIL PROTECTED] on 2008/09/07 11:31:53 *pending*
Change documentation of openFiles() to reflect code. Partial mimetypes
are
not yet supported.
PRESUBMIT=passed
R=bpm
[EMAIL PROTECTED]
DELTA=3 (1 added, 0 deleted, 2 changed)
OCL=8199719
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/api_desktop.html#7 edit
3 delta lines: 1 added, 0 deleted, 2 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8199719 by [EMAIL PROTECTED] on 2008/09/07 11:31:53 *pending*
Change documentation of openFiles() to reflect code. Partial mimetypes
are
not yet supported.
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/api_desktop.html#7 edit
==== //depot/googleclient/gears/opensource/gears/sdk/api_desktop.html#7 -
c:\src-gears2/googleclient/gears/opensource/gears/sdk/api_desktop.html ====
# action=edit type=text
--- googleclient/gears/opensource/gears/sdk/api_desktop.html 2008-09-07
11:32:01.000000000 -0700
+++ googleclient/gears/opensource/gears/sdk/api_desktop.html 2008-09-07
11:31:20.000000000 -0700
@@ -241,8 +241,9 @@
If a filter is provided, only files matching the filter are selectable.
The user can turn the filter off, so be aware that selected files
may not match the filter. The filter is an array of Internet
- content types and/or file extensions.
- Example: <code>['text/html', '.txt', 'image/*']</code></td>
+ content types and/or file extensions.<br><br>
+ Example: <code>['text/html', '.txt', 'image/png']</code><br><br>
+ Partial contenet types like 'image/*' are not yet supported.</td>
</tr>
</table>
