Patch is:
--- \\filer\home\build\googleclient\gears\opensource\gears\sdk\api_desktop.html
2008-08-21 16:06:34.484497000 -0700
+++ sdk\api_desktop.html 2008-09-07 13:18:55.250000000 -0700
@@ -240,9 +240,10 @@
<td class="odd">By default, all files on the local disk are selectable.
If a filter is provided, only files matching the filter are selectable.
The user can turn the filter off, so be aware that selected files
- may not match the filter. The filter is an array of Internet
- content types and/or file extensions.
- Example: <code>['text/html', '.txt', 'image/*']</code></td>
+ may not match the filter. The filter is an array of internet
+ content types and/or file extensions.<br><br>
+ Example: <code>['text/html', 'text/plain', '.mov']</code><br><br>
+ Partial content types like 'image/*' are not currently supported.</td>
- a
On Sun, Sep 7, 2008 at 1:19 PM, Aaron Boodman <[EMAIL PROTECTED]> wrote:
> New snapshot uploaded.
>
> On Sun, Sep 7, 2008 at 1:16 PM, Chris Prince <[EMAIL PROTECTED]> wrote:
>>
>> You might also consider changing "not yet supported" to "not currently
>> supported", depending on the message you want to give. The first
>> version implies "coming soon", while the latter is more a statement of
>> fact.
>>
>>
>> On Sun, Sep 7, 2008 at 1:13 PM, Chris Prince <[EMAIL PROTECTED]> wrote:
>>> That's my fault. When reviewing docs right before the 0.4 release, I
>>> saw "text/html" and "image/png" were both listed as examples, and I
>>> thought it was a typo.
>>>
>>> I like how you added an explicit note about "foo/*". Maybe remove
>>> "image/png" from the example, since it's redundant with "text/html"?
>>>
>>> Small typo: "contenet" --> "content"
>>>
>>>
>>> On Sun, Sep 7, 2008 at 11:32 AM, Aaron Boodman <[EMAIL PROTECTED]> wrote:
>>>> Hello bpm,
>>>>
>>>> I'd like you to do a code review. Please execute
>>>> g4 diff -c 8199719
>>>>
>>>> or point your web browser to
>>>> http://mondrian/8199719
>>>>
>>>> to review the following code:
>>>>
>>>> Change 8199719 by [EMAIL PROTECTED] on 2008/09/07 11:31:53 *pending*
>>>>
>>>> Change documentation of openFiles() to reflect code. Partial
>>>> mimetypes are
>>>> not yet supported.
>>>>
>>>> PRESUBMIT=passed
>>>> R=bpm
>>>> [EMAIL PROTECTED]
>>>> DELTA=3 (1 added, 0 deleted, 2 changed)
>>>> OCL=8199719
>>>>
>>>> Affected files ...
>>>>
>>>> ... //depot/googleclient/gears/opensource/gears/sdk/api_desktop.html #7
>>>> edit
>>>>
>>>> 3 delta lines: 1 added, 0 deleted, 2 changed
>>>>
>>>> If you can't do the review, please let me know as soon as possible. During
>>>> your review, please ensure that all new code has corresponding unit tests
>>>> and
>>>> that existing unit tests are updated appropriately. Visit
>>>> http://www/eng/code_review.html for more information.
>>>>
>>>> This is a semiautomated message from "g4 mail". Complaints or suggestions?
>>>> Mail [EMAIL PROTECTED]
>>>>
>>>
>>
>
