Hello michaeln,
I'd like you to do a code review. Please execute
g4 diff -c 8201059
or point your web browser to
http://mondrian/8201059
to review the following code:
Change 8201059 by [EMAIL PROTECTED] on 2008/09/08 16:32:03 *pending*
Add IE's IEHttpRequest and ProgressInputStream to the list of things
that we leak count, to bring it into parity with the Firefox port.
R=michaeln
[EMAIL PROTECTED]
DELTA=15 (14 added, 1 deleted, 0 changed)
OCL=8201059
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/common/leak_counter.cc#9
edit
... //depot/googleclient/gears/opensource/gears/base/common/leak_counter.h#8
edit
...
//depot/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.cc#18
edit
...
//depot/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.h#13
edit
...
//depot/googleclient/gears/opensource/gears/localserver/ie/progress_input_stream.cc#2
edit
15 delta lines: 14 added, 1 deleted, 0 changed
Also consider running:
g4 lint -c 8201059
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8201059 by [EMAIL PROTECTED] on 2008/09/08 16:32:03 *pending*
Add IE's IEHttpRequest and ProgressInputStream to the list of things
that we leak count, to bring it into parity with the Firefox port.
OCL=8201059
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/common/leak_counter.cc#9
edit
... //depot/googleclient/gears/opensource/gears/base/common/leak_counter.h#8
edit
...
//depot/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.cc#18
edit
...
//depot/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.h#13
edit
...
//depot/googleclient/gears/opensource/gears/localserver/ie/progress_input_stream.cc#2
edit
==== //depot/googleclient/gears/opensource/gears/base/common/leak_counter.cc#9
-
c:\devel\srcwingears2/googleclient/gears/opensource/gears/base/common/leak_counter.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/common/leak_counter.cc
2008-08-19 11:51:24.000000000 +1000
+++ googleclient/gears/opensource/gears/base/common/leak_counter.cc
2008-09-08 16:21:53.000000000 +1000
@@ -42,6 +42,7 @@
static const char16 *leak_counter_names[] = {
STRING16(L"DocumentJsRunner"),
STRING16(L"FFHttpRequest"),
+ STRING16(L"IEHttpRequest"),
STRING16(L"JavaScriptWorkerInfo"),
STRING16(L"JsArray"),
STRING16(L"JsCallContext"),
==== //depot/googleclient/gears/opensource/gears/base/common/leak_counter.h#8 -
c:\devel\srcwingears2/googleclient/gears/opensource/gears/base/common/leak_counter.h
====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/common/leak_counter.h
2008-09-08 16:32:23.000000000 +1000
+++ googleclient/gears/opensource/gears/base/common/leak_counter.h
2008-09-08 16:21:43.000000000 +1000
@@ -44,6 +44,7 @@
enum LeakCounterType {
LEAK_COUNTER_TYPE_DocumentJsRunner,
LEAK_COUNTER_TYPE_FFHttpRequest,
+ LEAK_COUNTER_TYPE_IEHttpRequest,
LEAK_COUNTER_TYPE_JavaScriptWorkerInfo,
LEAK_COUNTER_TYPE_JsArray,
LEAK_COUNTER_TYPE_JsCallContext,
====
//depot/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.cc#18
-
c:\devel\srcwingears2/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/localserver/ie/http_request_ie.cc
2008-09-08 16:32:24.000000000 +1000
+++ googleclient/gears/opensource/gears/localserver/ie/http_request_ie.cc
2008-09-08 16:43:09.000000000 +1000
@@ -31,6 +31,7 @@
#include "gears/localserver/ie/http_request_ie.h"
#include "gears/base/common/byte_store.h"
+#include "gears/base/common/leak_counter.h"
#include "gears/base/common/http_utils.h"
#include "gears/base/common/string_utils.h"
#include "gears/base/common/url_utils.h"
@@ -83,6 +84,11 @@
ready_state_(UNINITIALIZED),
has_synthesized_response_payload_(false),
async_(false) {
+ LEAK_COUNTER_INCREMENT(IEHttpRequest);
+}
+
+IEHttpRequest::~IEHttpRequest() {
+ LEAK_COUNTER_DECREMENT(IEHttpRequest);
}
HRESULT IEHttpRequest::FinalConstruct() {
====
//depot/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.h#13
-
c:\devel\srcwingears2/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.h
====
# action=edit type=text
--- googleclient/gears/opensource/gears/localserver/ie/http_request_ie.h
2008-09-08 16:32:24.000000000 +1000
+++ googleclient/gears/opensource/gears/localserver/ie/http_request_ie.h
2008-09-08 16:30:21.000000000 +1000
@@ -122,6 +122,7 @@
END_SERVICE_MAP()
IEHttpRequest();
+ ~IEHttpRequest();
HRESULT FinalConstruct();
void FinalRelease();
====
//depot/googleclient/gears/opensource/gears/localserver/ie/progress_input_stream.cc#2
-
c:\devel\srcwingears2/googleclient/gears/opensource/gears/localserver/ie/progress_input_stream.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/localserver/ie/progress_input_stream.cc
2008-09-08 16:32:24.000000000 +1000
+++ googleclient/gears/opensource/gears/localserver/ie/progress_input_stream.cc
2008-09-08 16:16:18.000000000 +1000
@@ -23,18 +23,22 @@
// OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
// ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#include "gears/localserver/ie/progress_input_stream.h"
+
+#include "gears/base/common/leak_counter.h"
#include "gears/localserver/common/progress_event.h"
#include "gears/localserver/ie/http_request_ie.h"
-#include "gears/localserver/ie/progress_input_stream.h"
//------------------------------------------------------------------------------
//ProgressInputStream implementation
//------------------------------------------------------------------------------
ProgressInputStream::ProgressInputStream() : request_(NULL) {
+ LEAK_COUNTER_INCREMENT(ProgressInputStream);
}
ProgressInputStream::~ProgressInputStream() {
+ LEAK_COUNTER_DECREMENT(ProgressInputStream);
// When the yahoo toolbar is installed, the stream gets released one too
// many times. We arrange to detect when this is occuring and avoid the
// extra release in that case.
