========================================================================
http://mondrian.corp.google.com/file/8201059///depot/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.cc?a=1
File 
//depot/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.cc 
(snapshot 1)
------------------------------------
Line 567: info->stgmedData.pstm = static_cast<IStream*>(stream);
Two things...

1) Now that we've added the ReleaseBindInfo call to the handler, I question
whether we're returning the stream properly here?

If the caller is expected to call ReleaseBindInfo which is expected to release
the stream, that leads me to believe that we should AddRef the stream we return
here.

2) With YahooToolbar installed, our handler is NOT registered, and things are
not well behaved. Can you also run thru the unit tests with YT installed and
check for leaks/crashes in that case.
========================================================================

-- 
To respond, reply to this email or visit http://mondrian.corp.google.com/8201059

Reply via email to