Hello mpcomplete,
I'd like you to do a code review. Please execute
g4 diff -c 8258647
or point your web browser to
http://mondrian/8258647
to review the following code:
Change 8258647 by [EMAIL PROTECTED] on 2008/09/12 12:08:34 *pending*
Adding sync messages so that Update Tasks can run in the browser
process. Updating the chrome plugin API.
R=mpcomplete
[EMAIL PROTECTED]
DELTA=344 (331 added, 2 deleted, 11 changed)
OCL=8258647
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/chrome/module_cr.cc#1 edit
... //depot/googleclient/gears/opensource/gears/base/chrome/module_cr.h#1 edit
... //depot/googleclient/gears/opensource/gears/base/common/async_router.cc#3
edit
... //depot/googleclient/gears/opensource/gears/base/common/async_router.h#2
edit
... //depot/googleclient/gears/opensource/gears/base/common/message_queue.h#14
edit
...
//depot/googleclient/gears/opensource/gears/localserver/chrome/update_task_cr.cc#1
edit
...
//depot/googleclient/gears/opensource/gears/localserver/chrome/update_task_cr.h#1
edit
...
//depot/googleclient/gears/opensource/gears/localserver/common/update_task.h#6
edit
...
//depot/googleclient/gears/opensource/third_party/chrome/chrome_plugin_api.h#1
edit
344 delta lines: 331 added, 2 deleted, 11 changed
Also consider running:
g4 lint -c 8258647
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
