Hello baran,
I'd like you to do a code review. Please execute
g4 diff -c 8316577
or point your web browser to
http://mondrian/8316577
to review the following code:
Change 8316577 by [EMAIL PROTECTED] on 2008/09/18 23:37:58 *pending*
Bug fix in mock network location provider CGI script.
Also limits precision of returned position for easier testing.
R=baran
[EMAIL PROTECTED]
DELTA=5 (0 added, 0 deleted, 5 changed)
OCL=8316577
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/cgi/location_provider.py#1
edit
5 delta lines: 0 added, 0 deleted, 5 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8316577 by [EMAIL PROTECTED] on 2008/09/18 23:37:58 *pending*
Bug fix in mock network location provider CGI script.
Also limits precision of returned position for easier testing.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/cgi/location_provider.py#1
edit
====
//depot/googleclient/gears/opensource/gears/test/testcases/cgi/location_provider.py#1
-
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/test/testcases/cgi/location_provider.py
====
# action=edit type=xtext
--- googleclient/gears/opensource/gears/test/testcases/cgi/location_provider.py
2008-09-18 23:41:35.000000000 +0100
+++ googleclient/gears/opensource/gears/test/testcases/cgi/location_provider.py
2008-09-18 23:39:22.000000000 +0100
@@ -66,7 +66,7 @@
return key_value
- def __HasValueInFixRequest(self, expected_value, key_name, outer_key):
+ def __HasValueInFixRequest(self, expected_value, inner_key, outer_key):
""" Checks if a key with the given value exists in the fix request.
Args:
@@ -86,8 +86,8 @@
continue
value = dictionary.get(inner_key, None)
- if (value == expected_value):
- found = True
+ if value == expected_value:
+ found = True
return found
@@ -113,8 +113,8 @@
# A valid position fix response, location data for the Google London office.
GOOD_JSON_RESPONSE = """{
"location": {
- "latitude": 51.590722643120145,
- "longitude": -1.494140625,
+ "latitude": 51.59,
+ "longitude": -1.49,
"altitude": 30,
"horizontal_accuracy": 1200,
"vertical_accuracy": 10,
