Hello steveblock,
I'd like you to do a code review. Please execute
g4 diff -c 8322063
or point your web browser to
http://mondrian/8322063
to review the following code:
Change 8322063 by [EMAIL PROTECTED] on 2008/09/19 13:46:02 *pending*
Fix for 1386303: jsoncpp parser seems very lenient and returns success
even when the input is malformed. We therefore relax the assertion that the
parsing result is always an object when the parser reports success.
BUG=1386303
R=steveblock
[EMAIL PROTECTED]
DELTA=10 (6 added, 0 deleted, 4 changed)
OCL=8322063
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/network_location_request.cc#26
edit
10 delta lines: 6 added, 0 deleted, 4 changed
The issue description(s) relevant to this code can be found at:
http://b/issue?id=1386303
or if you are using the old Bugs DB, at:
http://bugs.corp.google.com/show_bug.cgi?id=1386303
Also consider running:
g4 lint -c 8322063
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
