Uploaded new snapshot that connects the onunload hook to the browser via IPIEHTMLWindow2.
Andrei On Wed, Oct 1, 2008 at 7:18 PM, Andrei Popescu <[EMAIL PROTECTED]> wrote: > Hello steveblock, > > I'd like you to do a code review. Please execute > g4 diff -c 8450696 > > or point your web browser to > http://mondrian/8450696 > > to review the following code: > > Change 8450696 by [EMAIL PROTECTED] on 2008/10/01 18:54:33 *pending* > > Add unload monitoring to WinCE > > R=steveblock > [EMAIL PROTECTED] > DELTA=194 (176 added, 18 deleted, 0 changed) > OCL=8450696 > > Affected files ... > > ... //depot/googleclient/gears/opensource/gears/Makefile#185 edit > ... > //depot/googleclient/gears/opensource/gears/base/common/html_event_monitor.cc#1 > edit > ... > //depot/googleclient/gears/opensource/gears/base/common/html_event_monitor.h#2 > edit > ... > //depot/googleclient/gears/opensource/gears/base/common/html_event_monitor_iemobile.cc#1 > add > ... > //depot/googleclient/gears/opensource/gears/base/common/js_runner_ie.cc#19 > edit > ... > //depot/googleclient/gears/opensource/gears/base/common/wince_compatibility.cc#4 > edit > ... > //depot/googleclient/gears/opensource/gears/base/common/wince_compatibility.h#1 > edit > ... //depot/googleclient/gears/opensource/gears/factory/factory_impl.cc#17 > edit > ... //depot/googleclient/gears/opensource/gears/factory/factory_impl.h#4 edit > > 194 delta lines: 176 added, 18 deleted, 0 changed > > Also consider running: > g4 lint -c 8450696 > > which verifies that the changelist doesn't introduce new style violations. > > If you can't do the review, please let me know as soon as possible. During > your review, please ensure that all new code has corresponding unit tests and > that existing unit tests are updated appropriately. Visit > http://www/eng/code_review.html for more information. > > This is a semiautomated message from "g4 mail". Complaints or suggestions? > Mail [EMAIL PROTECTED] >
