On Mon, Oct 6, 2008 at 4:24 PM, Steve Block <[EMAIL PROTECTED]> wrote: > ======================================================================== > http://mondrian.corp.google.com/file/8450696///depot/googleclient/gears/opensource/gears/base/common/html_event_monitor_iemobile.cc?a=4 > File > //depot/googleclient/gears/opensource/gears/base/common/html_event_monitor_iemobile.cc > (snapshot 4) > ------------------------------------ > Line 28: #ifdef WINCE > But this file is only included in the build for WinCE. And if it were included > in other builds, wouldn't compilation fail (with or without this header > included)? So if there are to be guards, I think they should be around the > whole > file (as in file_wince.cc).
Ah yes, in that file you're right: no need for the include guard. I added the guard around he entire file instead. > ======================================================================== > http://mondrian.corp.google.com/file/8450696///depot/googleclient/gears/opensource/gears/base/common/wince_compatibility.h?a=5 > File > //depot/googleclient/gears/opensource/gears/base/common/wince_compatibility.h > (snapshot 5) > ------------------------------------ > Line 143: static UnloadEventHandlerInterface *s_handler_; > I'm not sure what the correct answer is, but in most places in the Gears code, > there's no special naming convention for static member variables. In some > places > the prefix 'g_' is used. The prefix 's_' is used in only one other place. Ok, removed the prefix. New snapshot uploaded.
