FYI

========================================================================
http://mondrian.corp.google.com/file/8527797///depot/googleclient/gears/opensource/gears/base/common/wince_compatibility.cc?a=1
File 
//depot/googleclient/gears/opensource/gears/base/common/wince_compatibility.cc 
(snapshot 1)
------------------------------------
Line 536: assert(mlang_library);
Can we be sure that the library is always present?
------------------------------------
Line 541: LcidToRfc1766W* ConvertLcidToRfc1766 = 
reinterpret_cast<LcidToRfc1766W*>(
This is a variable name so should be convert_lcid_to_rfc_1766_function.
------------------------------------
Line 543: HRESULT ret = ConvertLcidToRfc1766(locale_id,
assert(convert_lcid_to_rfc_1766_function); ?
------------------------------------
Line 545: sizeof(rfc_1766) / sizeof(rfc_1766[0]));
Use ARRAYSIZE?
------------------------------------
Line 549: *locale = rfc_1766;
assert(locale); ?
------------------------------------
Line 555: LCID locale_id;
Trailing whitespace.
========================================================================

-- 
To respond, reply to this email or visit http://mondrian.corp.google.com/8527797

Reply via email to