Thanks Steve! On Wed, Oct 8, 2008 at 3:48 PM, Steve Block <[EMAIL PROTECTED]> wrote: > ------------------------------------ > Line 536: assert(mlang_library); > Can we be sure that the library is always present?
Apparently yes. But better be safe than sorry, so failing gracefully now if it isn't present. > ------------------------------------ > Line 541: LcidToRfc1766W* ConvertLcidToRfc1766 = > reinterpret_cast<LcidToRfc1766W*>( > This is a variable name so should be convert_lcid_to_rfc_1766_function. Fixed. > ------------------------------------ > Line 543: HRESULT ret = ConvertLcidToRfc1766(locale_id, > assert(convert_lcid_to_rfc_1766_function); ? Fixed. > ------------------------------------ > Line 545: sizeof(rfc_1766) / sizeof(rfc_1766[0])); > Use ARRAYSIZE? Good point, fixed. > ------------------------------------ > Line 549: *locale = rfc_1766; > assert(locale); ? Asserted. > ------------------------------------ > Line 555: LCID locale_id; > Trailing whitespace. Removed. New snapshot uploaded.
