Hello mpcomplete,
I'd like you to do a code review. Please execute
g4 diff -c 8570507
or point your web browser to
http://mondrian/8570507
to review the following code:
Change 8570507 by [EMAIL PROTECTED] on 2008/10/12 14:54:11 *pending*
Make JsObject an interface rather than a class. This does for
JsObject what 8526081 did for JsArray.
PRESUBMIT=passed
R=mpcomplete
[EMAIL PROTECTED]
DELTA=470 (122 added, 37 deleted, 311 changed)
OCL=8570507
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/common/js_dom_element.cc#5
edit
... //depot/googleclient/gears/opensource/gears/base/common/js_dom_element.h#2
edit
... //depot/googleclient/gears/opensource/gears/base/common/js_marshal.cc#15
edit
... //depot/googleclient/gears/opensource/gears/base/common/js_marshal.h#6 edit
... //depot/googleclient/gears/opensource/gears/base/common/js_runner.h#17 edit
... //depot/googleclient/gears/opensource/gears/base/common/js_runner_cr.cc#4
edit
... //depot/googleclient/gears/opensource/gears/base/common/js_runner_ff.cc#31
edit
... //depot/googleclient/gears/opensource/gears/base/common/js_runner_ie.cc#21
edit
... //depot/googleclient/gears/opensource/gears/base/common/js_runner_np.cc#29
edit
... //depot/googleclient/gears/opensource/gears/base/common/js_types.cc#49 edit
... //depot/googleclient/gears/opensource/gears/base/common/js_types.h#38 edit
... //depot/googleclient/gears/opensource/gears/base/common/leak_counter.cc#11
edit
... //depot/googleclient/gears/opensource/gears/base/common/leak_counter.h#10
edit
... //depot/googleclient/gears/opensource/gears/cctests/test.cc#83 edit
... //depot/googleclient/gears/opensource/gears/database2/database2.cc#6 edit
... //depot/googleclient/gears/opensource/gears/database2/database2.h#6 edit
... //depot/googleclient/gears/opensource/gears/database2/transaction.cc#10 edit
... //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#51 edit
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_registry.cc#3
edit
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_registry.h#2
edit
... //depot/googleclient/gears/opensource/gears/desktop/file_dialog.cc#13 edit
... //depot/googleclient/gears/opensource/gears/desktop/file_dialog.h#7 edit
... //depot/googleclient/gears/opensource/gears/geolocation/geolocation.cc#55
edit
... //depot/googleclient/gears/opensource/gears/geolocation/geolocation.h#24
edit
...
//depot/googleclient/gears/opensource/gears/geolocation/geolocation_test.cc#27
edit
... //depot/googleclient/gears/opensource/gears/notifier/notification.cc#17 edit
470 delta lines: 122 added, 37 deleted, 311 changed
Also consider running:
g4 lint -c 8570507
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
