Hello noel,
I'd like you to do a code review. Please execute
g4 diff -c 8573993
or point your web browser to
http://mondrian/8573993
to review the following code:
Change 8573993 by [EMAIL PROTECTED] on 2008/10/13 14:09:23 *pending*
Fix drag-and-drop Firefox crasher. Previously, we were explicitly
deleting the DropTarget object. This was a latent bug that wasn't
problematic when the original feature was submitted, presumably
because we were leaking a number of things on Firefox, at the time.
Now that the leaks have been fixed, the explicit deletion of the
XPCOM (i.e. ref-counted) object is causing a crash when Firefox's
EventListener management code tries to follow a dangling pointer.
Instead, the correct thing to do (which is what this patch
introduces) is to balance any existing AddEventListener (and hence
AddRef) calls with RemoveEventListener (and hence Release) calls.
PRESUBMIT=passed
R=noel
[EMAIL PROTECTED]
DELTA=103 (72 added, 24 deleted, 7 changed)
OCL=8573993
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/common/leak_counter.cc#11
edit
... //depot/googleclient/gears/opensource/gears/base/common/leak_counter.h#10
edit
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_registry.cc#3
edit
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_registry.h#2
edit
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.cc#3 edit
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.h#1 edit
103 delta lines: 72 added, 24 deleted, 7 changed
Also consider running:
g4 lint -c 8573993
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
