> ========================================================================
> http://mondrian.corp.google.com/file/8551007///depot/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.cc?a=1
> File 
> //depot/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.cc 
> (snapshot 1)
> ------------------------------------
> Line 486: // skipped. We therefore handle these cases here.
> What do you mean by 'unknown domain' here? Does OnProgress get called for
> 'known' domains?
I mean a 'bad' domain, for which there's no DNS entry. In the test
testGet302NoCrossOriginBadDomain I use
'http://nosuchdomain___/nosuchfile___' as the URL. Yes, OnProgress
gets called for cross-origin redirects to valid domains. This is
tested in testGet302NoCrossOrigin.

> ========================================================================
> http://mondrian.corp.google.com/file/8551007///depot/googleclient/gears/opensource/gears/test/testcases/workerpool_createworkerfromurl_tests.js?a=1
> File 
> //depot/googleclient/gears/opensource/gears/test/testcases/workerpool_createworkerfromurl_tests.js
>  (snapshot 1)
> ------------------------------------
> Line 36: alert(location.href);
> Remove alert.
Done

> ========================================================================
> http://mondrian.corp.google.com/file/8551007///depot/googleclient/gears/opensource/gears/test/tester/assert.js?a=1
> File //depot/googleclient/gears/opensource/gears/test/tester/assert.js 
> (snapshot 1)
> ------------------------------------
> Line 454: // The cross origin path has the same host as currentUrl
> White space at the end.
Done

> ------------------------------------
> Line 456: var currentPort = currentUrl.substring(currentUrl.lastIndexOf(':') 
> + 1,
> and here.
Done

New snapshot uploaded.

Reply via email to