LGTM ======================================================================== http://mondrian.corp.google.com/file/8551007///depot/googleclient/gears/opensource/gears/test/testcases/httprequest_tests.js?a=3 File //depot/googleclient/gears/opensource/gears/test/testcases/httprequest_tests.js (snapshot 3) ------------------------------------ Line 30: var crossOriginUrl = 'http://www.google.com'; I'd explain why this needs to be a valid domain, so that the next engineer who pokes at this file won't change this in a way that breaks the wince tests. ------------------------------------ Line 131: var redirectUrl = 'http://nosuchdomain___/nosuchfile___'; Add a comment. ======================================================================== http://mondrian.corp.google.com/file/8551007///depot/googleclient/gears/opensource/gears/test/testcases/workerpool_createworkerfromurl_tests.js?a=3 File //depot/googleclient/gears/opensource/gears/test/testcases/workerpool_createworkerfromurl_tests.js (snapshot 3) ------------------------------------ Line 39: var crossOriginPath = A lot of whitespace at the end of the above lines. ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/8551007
