======================================================================== http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/base/common/base_class.h?a=1 File //depot/googleclient/gears/opensource/gears/base/common/base_class.h (snapshot 1) ------------------------------------ Line 47: class GearsFactory; I think this can be removed altogether, no? ======================================================================== http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/base/common/wince_compatibility.cc?a=1 File //depot/googleclient/gears/opensource/gears/base/common/wince_compatibility.cc (snapshot 1) ------------------------------------ Line 57: // Used by BrowserCache methods for IE. IE Mobile ------------------------------------ Line 263: #ifdef BROWSER_IE Can we collapse these into a single #ifdef? ------------------------------------ Line 264: // BrowserCache - used on IE. Mobile ======================================================================== http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/factory/factory_impl.cc?a=1 File //depot/googleclient/gears/opensource/gears/factory/factory_impl.cc (snapshot 1) ------------------------------------ Line 60: // Furthermore, Canvas, Console, Image and Media are unimplemented on IE on Nor will they ever be implemented on WinCE on any browser. So I'd leave just the OS check. ======================================================================== http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/sdk/gears_init.js?a=1 File //depot/googleclient/gears/opensource/gears/sdk/gears_init.js (snapshot 1) ------------------------------------ Line 50: // privateSetGlobalObject is only required and supported on IE on WinCE. Mobile ======================================================================== http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/sdk/samples/gearpad/utils.js?a=1 File //depot/googleclient/gears/opensource/gears/sdk/samples/gearpad/utils.js (snapshot 1) ------------------------------------ Line 208: // privateSetGlobalObject is only required and supported on IE on WinCE. Mobile ======================================================================== http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/sdk/samples/sample.js?a=1 File //depot/googleclient/gears/opensource/gears/sdk/samples/sample.js (snapshot 1) ------------------------------------ Line 26: // On some WinCE devices, IE uses 'unknown' rather than 'undefined'. If an Mobile ======================================================================== http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/test/tester/harness.js?a=1 File //depot/googleclient/gears/opensource/gears/test/tester/harness.js (snapshot 1) ------------------------------------ Line 225: // case on IE on WinCE. Mobile (here ane everywhere else) ======================================================================== http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/tools/config.mk?a=1 File //depot/googleclient/gears/opensource/gears/tools/config.mk (snapshot 1) ------------------------------------ Line 626: LIBTREMOR_CFLAGS += -DWINCE What do we need Tremor for?? ======================================================================== http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/ui/ie/html_dialog_host_iemobile.cc?a=1 File //depot/googleclient/gears/opensource/gears/ui/ie/html_dialog_host_iemobile.cc (snapshot 1) ------------------------------------ Line 600: } While you're here, you could fix this, too:
\No newline at end of file ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/8590922
