> ======================================================================== > http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/base/common/base_class.h?a=1 > File //depot/googleclient/gears/opensource/gears/base/common/base_class.h > (snapshot 1) > ------------------------------------ > Line 47: class GearsFactory; > I think this can be removed altogether, no? No, it's needed for IsFactoryInitialized.
> ======================================================================== > http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/base/common/wince_compatibility.cc?a=1 > File > //depot/googleclient/gears/opensource/gears/base/common/wince_compatibility.cc > (snapshot 1) > ------------------------------------ > Line 57: // Used by BrowserCache methods for IE. > IE Mobile Fixed throughout. > ------------------------------------ > Line 263: #ifdef BROWSER_IE > Can we collapse these into a single #ifdef? We could, but right now the ifdefs form logical groups for sets of functions, which I think makes things clearer. > ======================================================================== > http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/factory/factory_impl.cc?a=1 > File //depot/googleclient/gears/opensource/gears/factory/factory_impl.cc > (snapshot 1) > ------------------------------------ > Line 60: // Furthermore, Canvas, Console, Image and Media are unimplemented > on IE on > Nor will they ever be implemented on WinCE on any browser. So I'd leave just > the > OS check. Yeah, but I wanted to make clear it's due to them not being implemented for PIE, rather than a fundamental platform limitation. > ======================================================================== > http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/tools/config.mk?a=1 > File //depot/googleclient/gears/opensource/gears/tools/config.mk (snapshot 1) > ------------------------------------ > Line 626: LIBTREMOR_CFLAGS += -DWINCE > What do we need Tremor for?? Good point. Removed Tremor and Speex build from Makefile for WinCE. > ======================================================================== > http://mondrian.corp.google.com/file/8590922///depot/googleclient/gears/opensource/gears/ui/ie/html_dialog_host_iemobile.cc?a=1 > File > //depot/googleclient/gears/opensource/gears/ui/ie/html_dialog_host_iemobile.cc > (snapshot 1) > ------------------------------------ > Line 600: } > While you're here, you could fix this, too: > > \No newline at end of file Done New snapshot uploaded.
