...and submitted.

========================================================================
http://mondrian.corp.google.com/file/8651940///depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.cc?a=1
File //depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.cc 
(snapshot 1)
------------------------------------
Line 204: nsCOMPtr<nsISupportsString> data_as_xpcom_string = 
do_QueryInterface(data);
On Mon Oct 20 11:34:33 2008 PDT, aa wrote:
> Might be nice to add a bit of explanatory comment at the top of each of these
> branches...
> 
> On Linux, we got nsIURI and we must convert it to a file path.
> 
> On Windows and Mac, we got nsIFile ...

Done.
------------------------------------
Line 233: nr = local_file->SetFollowLinks(PR_TRUE);
On Mon Oct 20 11:38:39 2008 PDT, aa wrote:
> Not arguing against it, but I'm curious about the reasoning that led to
> following shortcuts on Windows. Is this the behavior of other drag and drop
> systems?

If you drop a shortcut onto IE (without Gears drag and drop) then it will follow
links. We're just mimicking that.
========================================================================

-- 
To respond, reply to this email or visit http://mondrian.corp.google.com/8651940

Reply via email to