Hello nicolasroard,
I'd like you to do a code review. Please execute
g4 diff -c 8763987
or point your web browser to
http://mondrian/8763987
(this changelist has been uploaded to Mondrian)
to review the following code:
Change 8763987 by [EMAIL PROTECTED] on 2008/10/28 17:20:38 *pending*
Fix compilation of Gears ICU-3.8 on Android.
We're removing a dependency on the system ICU library in
Android. It turns out we now use very little of the library,
so the code growth from using the Gears version instead is
tiny, and saves us from future version issues.
Android works properly with the same platform-speific defines
as Linux.
PRESUBMIT=passed
R=nicolasroard
CC=andreip,[email protected]
DELTA=2 (0 added, 0 deleted, 2 changed)
OCL=8763987
Affected files ...
... //depot/googleclient/gears/opensource/third_party/icu38/README.google#3 edit
...
//depot/googleclient/gears/opensource/third_party/icu38/public/common/unicode/umachine.h#2
edit
2 delta lines: 0 added, 0 deleted, 2 changed
Also consider running:
g4 lint -c 8763987
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8763987 by [EMAIL PROTECTED] on 2008/10/28 17:20:38 *pending*
Fix compilation of Gears ICU-3.8 on Android.
We're removing a dependency on the system ICU library in
Android. It turns out we now use very little of the library,
so the code growth from using the Gears version instead is
tiny, and saves us from future version issues.
Android works properly with the same platform-speific defines
as Linux.
Affected files ...
... //depot/googleclient/gears/opensource/third_party/icu38/README.google#3 edit
...
//depot/googleclient/gears/opensource/third_party/icu38/public/common/unicode/umachine.h#2
edit
==== //depot/googleclient/gears/opensource/third_party/icu38/README.google#3 -
/usr/local/google/home/jripley/gears-trunk2/googleclient/gears/opensource/third_party/icu38/README.google
====
# action=edit type=text
--- googleclient/gears/opensource/third_party/icu38/README.google
2008-10-28 17:21:30.000000000 +0000
+++ googleclient/gears/opensource/third_party/icu38/README.google
2008-10-28 17:18:20.000000000 +0000
@@ -12,7 +12,7 @@
- In public/common/unicode/utf.h:
"#define U_SENTINEL (-1)" is changed to "#define U_SENTINEL (~0)"
- In public/common/unicode/umachine.h we add:
- #elif defined(LINUX)
+ #elif defined(LINUX) || defined(OS_ANDROID)
# include "unicode/plinux.h"
- We add public/common/unicode/plinux.h It is generated as platform.h on a
linux machine via:
====
//depot/googleclient/gears/opensource/third_party/icu38/public/common/unicode/umachine.h#2
-
/usr/local/google/home/jripley/gears-trunk2/googleclient/gears/opensource/third_party/icu38/public/common/unicode/umachine.h
====
# action=edit type=text
---
googleclient/gears/opensource/third_party/icu38/public/common/unicode/umachine.h
2008-10-28 17:15:35.000000000 +0000
+++
googleclient/gears/opensource/third_party/icu38/public/common/unicode/umachine.h
2008-10-11 16:47:06.000000000 +0100
@@ -47,7 +47,7 @@
# include "unicode/pwin32.h"
#elif defined(__APPLE__)
# include "unicode/pmac.h"
-#elif defined(LINUX)
+#elif defined(LINUX) || defined(OS_ANDROID)
# include "unicode/plinux.h"
#else
# include "unicode/platform.h"
