Hello aa,
I'd like you to do a code review. Please execute
g4 diff -c 8772467
or point your web browser to
http://mondrian/8772467
to review the following code:
Change 8772467 by [EMAIL PROTECTED] on 2008/10/29 11:35:33 *pending*
Do not cancel the drop event, on IE.
This gives a nicer user experience on IE6, in that the GUI changes
from a drop are rendered immediately, instead of requiring an
extra click to re-focus the browser window.
PRESUBMIT=passed
R=aa
[EMAIL PROTECTED]
DELTA=2 (0 added, 2 deleted, 0 changed)
OCL=8772467
Affected files ...
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ie.cc#8 edit
2 delta lines: 0 added, 2 deleted, 0 changed
Also consider running:
g4 lint -c 8772467
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8772467 by [EMAIL PROTECTED] on 2008/10/29 11:35:33 *pending*
Do not cancel the drop event, on IE.
This gives a nicer user experience on IE6, in that the GUI changes
from a drop are rendered immediately, instead of requiring an
extra click.
Affected files ...
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ie.cc#8 edit
==== //depot/googleclient/gears/opensource/gears/desktop/drop_target_ie.cc#8 -
/home/nigeltao/srcgears3/googleclient/gears/opensource/gears/desktop/drop_target_ie.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/desktop/drop_target_ie.cc
2008-10-28 16:53:44.000000000 +1100
+++ googleclient/gears/opensource/gears/desktop/drop_target_ie.cc
2008-10-29 11:33:51.000000000 +1100
@@ -285,8 +285,6 @@
on_drop_.get(), argc, argv, NULL);
}
- hr = CancelEventBubble(html_event_obj, html_data_transfer);
- if (FAILED(hr)) return hr;
return S_OK;
}
