FYI ======================================================================== http://mondrian.corp.google.com/file/8931781///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_osx.h?a=5 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_osx.h (snapshot 5) ------------------------------------ Line 26: #ifndef GEARS_DESKTOP_DRAG_AND_DROP_UTILS_OSX_H__ Header guards shouldn't use double underscores at the end; I believe those are reserved for compiler usage nowadays. Change this to a single underscore. ======================================================================== http://mondrian.corp.google.com/file/8931781///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_osx.mm?a=7 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_osx.mm (snapshot 7) ------------------------------------ Line 39: static bool g_is_in_a_drag_operation_ = false; This doesn't seem particularly thread-safe; can you use NSLock or similar? ------------------------------------ Line 69: NSStringFromSelector(old_selector), You might as well indent these three lines two more spaces so they line up with the inside of the opening parenthesis. ------------------------------------ Line 77: - (NSDragOperation)swizzledDraggingEntered:(id <NSDraggingInfo>) draggingInfo; Ditch the spaces between "(id <NSDraggingInfo>)" and "draggingInfo", as well as the other instances below. ------------------------------------ Line 83: @implementation WebView (GearsSwizzledMethods) Add a blank line after @implementation. ------------------------------------ Line 119: @end Add a blank line before @end. ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/8931781
