LGTM ======================================================================== http://mondrian.corp.google.com/file/8931781///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_osx.h?a=5 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_osx.h (snapshot 5) ------------------------------------ Line 26: #ifndef GEARS_DESKTOP_DRAG_AND_DROP_UTILS_OSX_H__ On Tue Nov 11 20:39:43 2008 PST, nigeltao wrote: > On Tue Nov 11 19:58:28 2008 PST, dsymonds wrote: > > Header guards shouldn't use double underscores at the end; I believe those are > > reserved for compiler usage nowadays. Change this to a single underscore. > > All of Gears uses the double-underscore, so I'll leave it as is.
Sure, but it might be worth keeping it in mind. A future version of GCC will probably start complaining about it. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/8931781
