LGTM ======================================================================== http://mondrian.corp.google.com/file/9051842///depot/googleclient/gears/opensource/gears/base/common/position_table.cc?a=1 File //depot/googleclient/gears/opensource/gears/base/common/position_table.cc (snapshot 1) ------------------------------------ Line 228: switch (error_code) { This isn't backwards compatible but I guess it doesn't need to be, right? E.g. if the error_code was 3 (NOT_FOUND in the old version of the spec), now it will be mapped to CODE_NONE. ======================================================================== http://mondrian.corp.google.com/file/9051842///depot/googleclient/gears/opensource/gears/geolocation/geolocation.h?a=1 File //depot/googleclient/gears/opensource/gears/geolocation/geolocation.h (snapshot 1) ------------------------------------ Line 84: // W3C spec. Add a comment explaining why the rest of the codes are missing. ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/9051842
