> ========================================================================
> http://mondrian.corp.google.com/file/9051842///depot/googleclient/gears/opensource/gears/base/common/position_table.cc?a=1
> File 
> //depot/googleclient/gears/opensource/gears/base/common/position_table.cc 
> (snapshot 1)
> ------------------------------------
> Line 228: switch (error_code) {
> This isn't backwards compatible but I guess it doesn't need to be, right?
Correct. This is because we only store good positions in the DB (ie
those where the error code is kint32min). See the CL description.

> ========================================================================
> http://mondrian.corp.google.com/file/9051842///depot/googleclient/gears/opensource/gears/geolocation/geolocation.h?a=1
> File //depot/googleclient/gears/opensource/gears/geolocation/geolocation.h 
> (snapshot 1)
> ------------------------------------
> Line 84: // W3C spec.
> Add a comment explaining why the rest of the codes are missing.
Done.

Lesley, would you mind checking that the HTML/CSS change is OK for the codesite?

New snapshot uploaded.

Reply via email to