Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 9069602
or point your web browser to
http://mondrian/9069602
(this changelist has been uploaded to Mondrian)
to review the following code:
Change 9069602 by [EMAIL PROTECTED] on 2008/11/19 12:31:21 *pending*
Change hard-coded arm-eabi-strip to use CROSS_PREFIX.
Fixes Android install rule when arm-eabi-strip is not in PATH,
but CROSS_PREFIX can locate it.
PRESUBMIT=passed
R=andreip
[EMAIL PROTECTED]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=9069602
Affected files ...
... //depot/googleclient/gears/opensource/gears/tools/rules.mk#93 edit
1 delta lines: 0 added, 0 deleted, 1 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 9069602 by [EMAIL PROTECTED] on 2008/11/19 12:31:21 *pending*
Change hard-coded arm-eabi-strip to use CROSS_PREFIX.
Fixes Android install rule when arm-eabi-strip is not in PATH,
but CROSS_PREFIX can locate it.
Affected files ...
... //depot/googleclient/gears/opensource/gears/tools/rules.mk#93 edit
==== //depot/googleclient/gears/opensource/gears/tools/rules.mk#93 -
/usr/local/google/home/jripley/gears-trunk2/googleclient/gears/opensource/gears/tools/rules.mk
====
# action=edit type=text
--- googleclient/gears/opensource/gears/tools/rules.mk 2008-11-19
12:14:44.000000000 +0000
+++ googleclient/gears/opensource/gears/tools/rules.mk 2008-11-19
12:29:20.000000000 +0000
@@ -1184,7 +1184,7 @@
@echo "Copy $<"
@cp $< $@
@echo "Strip $<"
- @arm-eabi-strip $@
+ @$(CROSS_PREFIX)strip $@
$(ANDROID_INSTALLER_OUTDIR)/%.html: $(NPAPI_OUTDIR)/genfiles/%.html.compress
@echo "Copy `basename [EMAIL PROTECTED]"
