======================================================================== http://mondrian.corp.google.com/file/9069149///depot/googleclient/gears/opensource/gears/Makefile?a=0 File //depot/googleclient/gears/opensource/gears/Makefile ------------------------------------ Line 2291: safe_http_request.cc \ On 2:46 pm, steveblock wrote: > This works, but it's a little misleading. safe_http_request.cc is used by all 3 > NPAPI browsers (Chrome, Opera, Android), but it's now included in only the > 'localserver/android' section. Maybe ... > - Add it back to CHROME_CPPSRCS and OPERA_CPPSRCS and also to a new > ANDROID_CPPSRCS > - Move it to the 'localserver/npapi' section and add it to NPAPI_SOURCES. > - Move it the 'localserver/common' section (which is where the file actually > resides), add it to $(BROWSER_SOURCES) and ifdef the contents of the file for > BROWSER_NPAPI.
I like the last option, and that's what I've done now. safe_http_request.cc is now removed from all individual browsers, added to the common section, and an #ifdef BROWSER_NPAPI guard added to the file itself. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/9069149
