Hello steveblock,
I'd like you to do a code review. Please execute
g4 diff -c 9069149
or point your web browser to
http://mondrian/9069149
(this changelist has been uploaded to Mondrian)
to review the following code:
Change 9069149 by [EMAIL PROTECTED] on 2008/11/19 11:26:42 *pending*
Fix duplicate safe_http_request.cpp in Chrome build.
The merge of the Android build system introduced a duplicate
instance of safe_http_request.cpp. The linker throws a warning
about this and discards one of them.
This change removes the CHROME_CPPSRCS instance.
PRESUBMIT=passed
R=steveblock
[EMAIL PROTECTED]
DELTA=1 (0 added, 1 deleted, 0 changed)
OCL=9069149
Affected files ...
... //depot/googleclient/gears/opensource/gears/Makefile#211 edit
1 delta lines: 0 added, 1 deleted, 0 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 9069149 by [EMAIL PROTECTED] on 2008/11/19 11:26:42 *pending*
Fix duplicate safe_http_request.cpp in Chrome build.
The merge of the Android build system introduced a duplicate
instance of safe_http_request.cpp. The linker throws a warning
about this and discards one of them.
This change removes the CHROME_CPPSRCS instance.
OCL=9069149
Affected files ...
... //depot/googleclient/gears/opensource/gears/Makefile#211 edit
==== //depot/googleclient/gears/opensource/gears/Makefile#211 -
/usr/local/google/home/jripley/gears-trunk/googleclient/gears/opensource/gears/Makefile
====
# action=edit type=text
--- googleclient/gears/opensource/gears/Makefile 2008-11-19
12:14:55.000000000 +0000
+++ googleclient/gears/opensource/gears/Makefile 2008-11-19
11:35:08.000000000 +0000
@@ -2288,7 +2288,6 @@
network_intercept_cr.cc \
http_cookies_cr.cc \
http_request_cr.cc \
- safe_http_request.cc \
update_task_cr.cc \
$(NULL)
