Hello aa,

I'd like you to do a code review.  Please execute
        g4 diff -c 9101080

or point your web browser to
        http://mondrian/9101080

to review the following code:

Change 9101080 by [EMAIL PROTECTED] on 2008/11/20 18:18:01 *pending*

        Minor JSON reader mods
        * advance over UTF8 BOMs (if present) at the beginning of the byte 
stream instead of failing
        * allow unicode non-breaking space (char 0xa0) as whitespace, some 
templating/page-generation systems are prone to insert different flavors of 
spaces
        
        R=aa
        [EMAIL PROTECTED]
        DELTA=15  (14 added, 0 deleted, 1 changed)
        OCL=9101080

Affected files ...

... //depot/googleclient/gears/opensource/third_party/jsoncpp/json_reader.cc#2 
edit

15 delta lines: 14 added, 0 deleted, 1 changed

Also consider running:
        g4 lint -c 9101080

which verifies that the changelist doesn't introduce new style violations.

If you can't do the review, please let me know as soon as possible.  During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately.  Visit
http://www/eng/code_review.html for more information.

This is a semiautomated message from "g4 mail".  Complaints or suggestions?
Mail [EMAIL PROTECTED]

Reply via email to