Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 9106605
or point your web browser to
http://mondrian/9106605
to review the following code:
Change 9106605 by [EMAIL PROTECTED] on 2008/11/21 13:55:04 *pending*
Bug fix in assertArrayEqual.
R=andreip
[EMAIL PROTECTED]
DELTA=2 (0 added, 0 deleted, 2 changed)
OCL=9106605
Affected files ...
... //depot/googleclient/gears/opensource/gears/test/tester/assert.js#12 edit
2 delta lines: 0 added, 0 deleted, 2 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 9106605 by [EMAIL PROTECTED] on 2008/11/21 13:55:04 *pending*
Bug fix in assertArrayEqual.
Affected files ...
... //depot/googleclient/gears/opensource/gears/test/tester/assert.js#12 edit
==== //depot/googleclient/gears/opensource/gears/test/tester/assert.js#12 -
c:\MyDocs\Gears3/googleclient/gears/opensource/gears/test/tester/assert.js ====
# action=edit type=text
--- googleclient/gears/opensource/gears/test/tester/assert.js 2008-11-05
14:38:59.000000000 +0000
+++ googleclient/gears/opensource/gears/test/tester/assert.js 2008-11-21
11:24:26.000000000 +0000
@@ -181,7 +181,7 @@
assert(expected.length == actual.length, function() {
var message = 'Expected array length: %s actual length: %s'.subs(
expected.length, actual.length);
- formatErrorMessage(message, optDescription);
+ return formatErrorMessage(message, optDescription);
});
for (var i = 0; i < expected.length; ++expected) {
@@ -189,7 +189,7 @@
var message = 'Expected element in array at %s: %s (%s) actual: %s (%s)'
.subs(i, expected[i], typeof expected[i], actual[i],
typeof actual[i]);
- formatErrorMessage(message, optDescription);
+ return formatErrorMessage(message, optDescription);
});
}
}
