A few bugs and nits in-line. ======================================================================== http://mondrian.corp.google.com/file/9177551///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_sf.mm?a=5 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_sf.mm (snapshot 5) ------------------------------------ Line 41: nit: are these member variable? remove the trailing _ ------------------------------------ Line 87: could we just assert here:
assert(g_dragging_pasteboard_filenames_.empty()); and do the clearing in swizzledPerformDragOperation()? to match swizzledDraggingExited()? ------------------------------------ Line 195: return; error_out is of type std::string16* but the caller expects bool, hrnce type coercion and a side-effect not reseting g_dragging_pasteboard_filenames [via .clear()] at the called site. please fix that first, so I can work out your intent here and have another look. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/9177551
