By "done", I mean, "done, in CL 9182887". ======================================================================== http://mondrian.corp.google.com/file/9177551///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_sf.mm?a=5 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_sf.mm (snapshot 5) ------------------------------------ Line 41: On 2:36 pm, noel wrote: > nit: are these member variable? remove the trailing _
Done. ------------------------------------ Line 87: On 2:36 pm, noel wrote: > could we just assert here: > > assert(g_dragging_pasteboard_filenames_.empty()); > > and do the clearing in swizzledPerformDragOperation()? > to match swizzledDraggingExited()? Done. ------------------------------------ Line 195: return; On 2:37 pm, noel wrote: > error_out is of type std::string16* but the caller expects bool, hrnce type > coercion and a side-effect not reseting > g_dragging_pasteboard_filenames [via .clear()] at the called site. > > please fix that first, so I can work out your intent here > and have another look. Done. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/9177551
