LGTM ======================================================================== http://mondrian.corp.google.com/file/9194769///depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.cc?a=1 File //depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.cc (snapshot 1) ------------------------------------ Line 1309: JavaString(static_cast<jstring>(result)).ToString16(&local_value); Why do you use local_value then copy to value? ------------------------------------ Line 1312: std::string16 content_type_name(HttpConstants::kContentTypeHeader); Do you need this local variable, or can you test against HttpConstants::kContentTypeHeader directly? ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/9194769
