Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 9282447
or point your web browser to
http://mondrian/9282447
to review the following code:
Change 9282447 by [EMAIL PROTECTED] on 2008/12/05 12:39:15 *pending*
Updates Geolocation network protocol doc to reflect addition of reverse
geocoding.
R=andreip
[EMAIL PROTECTED]
DELTA=4 (3 added, 0 deleted, 1 changed)
OCL=9282447
Affected files ...
...
//depot/googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html#6
edit
4 delta lines: 3 added, 0 deleted, 1 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 9282447 by [EMAIL PROTECTED] on 2008/12/05 12:39:15 *pending*
Updates Geolocation network protocol doc to reflect addition of reverse
geocoding.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html#6
edit
====
//depot/googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html#6
-
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html
====
# action=edit type=text
--- googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html
2008-12-05 12:40:16.000000000 +0000
+++ googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html
2008-12-05 12:38:18.000000000 +0000
@@ -405,7 +405,10 @@
</tr>
<tr>
<td class="nameColumn">accuracy</td>
- <td class="descriptionColumn">The horizontal accuracy of the fix, in
meters at a 95% confidence level.</td>
+ <td class="descriptionColumn">
+ The horizontal accuracy of the fix, in meters at a 95% confidence level.
+ This is required unless the request specified a valid location object,
i.e. a request for a reverse-geocode of a known position.
+ </td>
<td class="requiredColumn">No</td>
<td class="typeColumn">double</td>
</tr>
