Hello nicolasroard, jripley,
I'd like you to do a code review. Please execute
g4 diff -c 9446584
or point your web browser to
http://mondrian/9446584
to review the following code:
Change 9446584 by andr...@andreip-gearslinux on 2008/12/17 10:41:00 *pending*
Fix for the 9439364 fix: we need to return not break if
the child is in COMPLETE.
PRESUBMIT=passed
R=nicolasroard,jripley
[email protected]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=9446584
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.cc#5
edit
1 delta lines: 0 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 9446584
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9446584 by andr...@andreip-gearslinux on 2008/12/17 10:41:00 *pending*
Fix for the 9439364 fix: we need to return not break if
the child is in COMPLETE.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.cc#5
edit
====
//depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.cc#5
-
/home/andreip/Gears/googleclient/gears/opensource/gears/localserver/android/http_request_android.cc
====
# action=edit type=text
---
googleclient/gears/opensource/gears/localserver/android/http_request_android.cc
2008-12-17 10:41:28.000000000 +0000
+++
googleclient/gears/opensource/gears/localserver/android/http_request_android.cc
2008-12-17 10:38:13.000000000 +0000
@@ -763,7 +763,7 @@
if (IsChildThread()) {
// Looks like we've been aborted before we branched here.
assert(was_aborted_);
- break;
+ return;
}
// Shut down the child thread now, otherwise we have to wait
