Hello andreip, nigeltao,
I'd like you to do a code review. Please execute
g4 diff -c 9446932
or point your web browser to
http://mondrian/9446932
to review the following code:
Change 9446932 by stevebl...@steveblock-gears3 on 2008/12/17 11:29:47 *pending*
Modifies drop_target_registration files to use
GEARS_DRAG_AND_DROP_API_IS_SUPPORTED_FOR_THIS_PLATFORM. Mailed on behalf of
Opera.
R=andreip,nigeltao
[email protected],[email protected]
DELTA=10 (0 added, 6 deleted, 4 changed)
OCL=9446932
Affected files ...
...
//depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.cc#2
edit
...
//depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.h#2
edit
10 delta lines: 0 added, 6 deleted, 4 changed
Also consider running:
g4 lint -c 9446932
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9446932 by stevebl...@steveblock-gears3 on 2008/12/17 11:29:47 *pending*
Modifies drop_target_registration files to use
GEARS_DRAG_AND_DROP_API_IS_SUPPORTED_FOR_THIS_PLATFORM. Mailed on behalf of
Opera.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.cc#2
edit
...
//depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.h#2
edit
====
//depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.cc#2
-
c:\MyDocs\Gears3/googleclient/gears/opensource/gears/desktop/drop_target_registration.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/desktop/drop_target_registration.cc
2008-12-17 11:56:16.000000000 +0000
+++ googleclient/gears/opensource/gears/desktop/drop_target_registration.cc
2008-12-17 11:54:44.000000000 +0000
@@ -26,10 +26,7 @@
#ifdef OFFICIAL_BUILD
// The Drag-and-Drop API has not been finalized for official builds.
#else
-#if defined(BROWSER_CHROME) || defined(OS_WINCE) || defined(OS_ANDROID)
- // The Drag-and-Drop API has not been implemented for Chrome,
- // PocketIE, and Android.
-#else
+#ifdef GEARS_DRAG_AND_DROP_API_IS_SUPPORTED_FOR_THIS_PLATFORM
#include "gears/desktop/drop_target_registration.h"
@@ -64,5 +61,5 @@
}
-#endif // BROWSER_CHROME, OS_WINCE, OS_ANDROID
+#endif // GEARS_DRAG_AND_DROP_API_IS_SUPPORTED_FOR_THIS_PLATFORM
#endif // OFFICIAL_BUILD
====
//depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.h#2
-
c:\MyDocs\Gears3/googleclient/gears/opensource/gears/desktop/drop_target_registration.h
====
# action=edit type=text
--- googleclient/gears/opensource/gears/desktop/drop_target_registration.h
2008-12-17 11:56:16.000000000 +0000
+++ googleclient/gears/opensource/gears/desktop/drop_target_registration.h
2008-12-17 11:29:50.000000000 +0000
@@ -28,10 +28,7 @@
#ifdef OFFICIAL_BUILD
// The Drag-and-Drop API has not been finalized for official builds.
#else
-#if defined(BROWSER_CHROME) || defined(OS_WINCE) || defined(OS_ANDROID)
- // The Drag-and-Drop API has not been implemented for Chrome,
- // PocketIE, and Android.
-#else
+#ifdef GEARS_DRAG_AND_DROP_API_IS_SUPPORTED_FOR_THIS_PLATFORM
#include "gears/base/common/base_class.h"
#include "gears/base/common/js_types.h"
@@ -62,6 +59,6 @@
DISALLOW_EVIL_CONSTRUCTORS(GearsDropTargetRegistration);
};
-#endif // BROWSER_CHROME, OS_WINCE, OS_ANDROID
+#endif // GEARS_DRAG_AND_DROP_API_IS_SUPPORTED_FOR_THIS_PLATFORM
#endif // OFFICIAL_BUILD
#endif // GEARS_DESKTOP_DROP_TARGET_REGISTRATION_H__
