On Wed, 17 Dec 2008 13:00:46 +0100, Steve Block <[email protected]>
wrote:
========================================================================
http://mondrian.corp.google.com/file/9446932///depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.cc?a=1
File
//depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.cc
(snapshot 1)
------------------------------------
Line 29: #ifdef GEARS_DRAG_AND_DROP_API_IS_SUPPORTED_FOR_THIS_PLATFORM
This is probably a sensible change, but I just wanted to check that it's
not
required (though the existing comment is misleading). Gears for Opera
Mobile
should be built with OS_WINCE defined.
Opera is built with OS_WINCE on WinMob, but it is not on desktop. Instead
of checking for Opera explicitly I thought that we could use your existing
generic feature define instead.
If you are to use
GEARS_DRAG_AND_DROP_API_IS_SUPPORTED_FOR_THIS_PLATFORM, you
need to include drop_target_base.h first, else the variable will never be
defined.
Of course, sorry for that slip. Will fix that in our code. Do you want me
to submit a new patch for it or could you add it for me?
--
Stig Halvorsen
Senior Core Developer
Opera Software ASA
