Hello benm,
I'd like you to do a code review. Please execute
g4 diff -c 9464365
or point your web browser to
http://mondrian/9464365
to review the following code:
Change 9464365 by stevebl...@steveblock-gears3 on 2008/12/18 12:56:08 *pending*
Fixes a class name in OperaUtils.
R=benm
[email protected]
DELTA=8 (1 added, 0 deleted, 7 changed)
OCL=9464365
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/opera/opera_utils.cc#1 edit
... //depot/googleclient/gears/opensource/gears/base/opera/opera_utils.h#1 edit
8 delta lines: 1 added, 0 deleted, 7 changed
Also consider running:
g4 lint -c 9464365
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9464365 by stevebl...@steveblock-gears3 on 2008/12/18 12:56:08 *pending*
Fixes a class name in OperaUtils.
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/opera/opera_utils.cc#1 edit
... //depot/googleclient/gears/opensource/gears/base/opera/opera_utils.h#1 edit
==== //depot/googleclient/gears/opensource/gears/base/opera/opera_utils.cc#1 -
c:\MyDocs\Gears3/googleclient/gears/opensource/gears/base/opera/opera_utils.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/opera/opera_utils.cc
2008-12-16 16:39:40.000000000 +0000
+++ googleclient/gears/opensource/gears/base/opera/opera_utils.cc
2008-12-16 15:46:58.000000000 +0000
@@ -115,18 +115,19 @@
};
// static
-OperaGearsAPI *OperaUtils::opera_api_ = NULL;
+OperaGearsApiInterface *OperaUtils::opera_api_ = NULL;
// static
ThreadId OperaUtils::browser_thread_ = 0;
//static
-void OperaUtils::Init(OperaGearsAPI *opera_api, ThreadId browser_thread) {
+void OperaUtils::Init(OperaGearsApiInterface *opera_api,
+ ThreadId browser_thread) {
opera_api_ = opera_api;
browser_thread_ = browser_thread;
}
// static
-OperaGearsAPI *OperaUtils::GetBrowserApiForGears() {
+OperaGearsApiInterface *OperaUtils::GetBrowserApiForGears() {
assert(opera_api_ != NULL);
return opera_api_;
}
==== //depot/googleclient/gears/opensource/gears/base/opera/opera_utils.h#1 -
c:\MyDocs\Gears3/googleclient/gears/opensource/gears/base/opera/opera_utils.h
====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/opera/opera_utils.h
2008-12-16 16:39:40.000000000 +0000
+++ googleclient/gears/opensource/gears/base/opera/opera_utils.h
2008-12-16 15:46:59.000000000 +0000
@@ -32,7 +32,7 @@
#include "gears/base/common/message_queue.h" // for ThreadId
-class OperaGearsAPI;
+class OperaGearsApiInterface;
class OperaWorkerThreadInterface;
class OperaUtils {
@@ -40,10 +40,10 @@
// Called by Opera when it first loads Gears. opera_api points to an object
// that implements the Opera API for Gears. browser_thread must be
// set to the ID of the thread Opera runs on.
- static void Init(OperaGearsAPI *opera_api, ThreadId browser_thread);
+ static void Init(OperaGearsApiInterface *opera_api, ThreadId browser_thread);
// Returns the pointer to the Opera API for Gears.
- static OperaGearsAPI *GetBrowserApiForGears();
+ static OperaGearsApiInterface *GetBrowserApiForGears();
// Returns the ID of the thread the browser runs on.
static ThreadId GetBrowserThreadId();
@@ -56,7 +56,7 @@
private:
// Holds the pointer to the global Opera API for Gears.
- static OperaGearsAPI *opera_api_;
+ static OperaGearsApiInterface *opera_api_;
// Holds the ID of the thread the browser runs on.
static ThreadId browser_thread_;
